• gcc warnings after upgrading mosquitto to 2.1.2

    From Nick Boel@1:103/705 to GitLab issue in main/sbbs on Thursday, April 09, 2026 16:33:50
    open https://gitlab.synchro.net/main/sbbs/-/issues/1119

    ```
    In file included from mqtt.h:36,
    from logfile.h:26,
    from sbbs.h:298,
    from js_conio.cpp:26:
    /usr/include/mqtt_protocol.h:2:2: warning: #warning "Please replace '#include <mqtt_protocol.h> with #include <mosquitto.h>" [-Wcpp]
    2 | #warning "Please replace '#include <mqtt_protocol.h> with #include <mosquitto.h>"
    | ^~~~~~~
    ```

    Seems to occur anywhere mqtt_protocol.h is called.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nick Boel@1:103/705 to GitLab note in main/sbbs on Sunday, August 23, 2026 07:33:19
    https://gitlab.synchro.net/main/sbbs/-/issues/1119#note_10202

    Not sure why it took me 4 months to actually dig into this a tiny bit to actually see and try to understand this - and I imagine it's probably already known by the devs, but I noticed /usr/include/mqtt_protocol.h contains:

    ```
    #include <mosquitto/mqtt_protocol.h>
    #warning "Please replace '#include <mqtt_protocol.h> with #include <mosquitto.h>"
    ```

    /usr/include/mosquitto/mqtt_protocol.h contains everything needed, and then /usr/include/mosquitto.h includes /usr/include/mosquitto/mqtt_protocol.h.

    So, is this just a warning that has come up in the latest version of mqtt (ie, not much to do with Synchronet except that Synchronet is still probably using /usr/include/mqtt_protocol.h at this point) all because mqtt_protocol.h is being moved to a new location?

    I suppose this would lead me to believe this issue has been left open as a reminder that once mqtt is updated in more "stable" distros that this change should be made?

    If so, kudos to upstream for giving plenty of fair warning (pun intended)!
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Friday, September 11, 2026 17:30:33
    close https://gitlab.synchro.net/main/sbbs/-/issues/1119
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nigel Reed@1:103/705 to GitLab note in main/sbbs on Tuesday, September 15, 2026 18:07:47
    https://gitlab.synchro.net/main/sbbs/-/issues/1119#note_10363


    ```
    <nelgin> 2 | #warning "Please replace '#include <mqtt_protocol.h> with #include <mosquitto.h>"
    <nelgin> | ^~~~~~~
    <nelgin> /usr/include/mqtt_protocol.h:2:2: warning: #warning "Please replace '#include <mqtt_protocol.h> with #include <mosquitto.h>" [-Wcpp]
    <DigitalMan> best to deal with that when I have a system that reproduces it
    ```

    I reported this issue on May 4th on IRC and was dismissed. Must be nice to have status.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, September 15, 2026 20:50:35
    https://gitlab.synchro.net/main/sbbs/-/issues/1119#note_10370

    One person reported the issue here (how it's supposed to be done) and another fixed it. You did neither. Nothing to do with status.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nigel Reed@1:103/705 to GitLab note in main/sbbs on Tuesday, September 15, 2026 21:47:18
    https://gitlab.synchro.net/main/sbbs/-/issues/1119#note_10371

    I read your comment as "if I cannot produce the warning then I'm not going to fix it" so I didn't bother. If you told me to open an issue then I would have.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, September 15, 2026 21:57:19
    https://gitlab.synchro.net/main/sbbs/-/issues/1119#note_10372

    I didn't fix it, someone else id (that presumably *could* reproduce it).
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, September 15, 2026 21:57:28
    https://gitlab.synchro.net/main/sbbs/-/issues/1119#note_10372

    I didn't fix it, someone else did (that presumably *could* reproduce it).
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)