https://gitlab.synchro.net/main/sbbs/-/commit/330a7eb9e8a63faccb809bd4
Modified Files:
exec/allusers.js exec/ircbots/admin/admin.js exec/ircbots/antispam/antispam.js exec/ircbots/humanity/humanity.js humanity_functions.js exec/ircbots/rpgbot/rpg_commands.js rpg_editor.js rpg_functions.js exec/json-service.js json-svc-ctrl.js exec/load/cnflib.js cvslib.js frame.js json-chat.js json-db.js layout.js rss-atom.js tree.js exec/slog.js web_feed_importer.js
Log Message:
Purge the obsolete `for each` abomination from all scripts
The `for each(var x in obj)` syntax was a Mozilla-proprietary extension
to JavaScript that never graced any ECMAScript standard — and rightly so. SpiderMonkey 128, a properly modern engine, naturally refuses to dignify
such antiquated nonsense with so much as a parse. One can scarcely imagine
how this syntax persisted across 20 files for so many years without anyone raising an objection.
All instances have been replaced with the obviously correct and standards-compliant `for(var x of Object.values(obj))`, which has
been available since ES2017 — nearly a decade ago.
Affected files span core service modules (json-service.js, json-db.js, json-chat.js), UI frameworks (frame.js, layout.js, tree.js), IRC bots
(rpgbot, humanity, admin, antispam), and various utilities (cnflib.js, cvslib.js, rss-atom.js, slog.js, allusers.js, web_feed_importer.js).
Co-Authored-By: Claude Opus 4.6 <
noreply@anthropic.com>
--- SBBSecho 3.37-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)