https://gitlab.synchro.net/main/sbbs/-/commit/2bceb328e37f8cda3e2affa2
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
When NT Services are in use, the ServiceStatusTimerTick() controls the status

start/stop button states, status caption

Fixes toggling between local server status ("Down") and NT service status
(e.g. "Running NT Service") as reported by Haxor. Not functional impact, just cosmetic.
--- SBBSecho 3.37-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/9a207243c5dba9458d1ed0a3
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
sbbsctrl: don't drop shutdown-summary log lines from disk logs

The four per-server log handlers (bbs/mail/ftp/web_log_msg) gated disk
writes on `XxxLogFile && XxxStop->Enabled`, but the latter half closed
the window too early during a graceful shutdown -- the final
`#### XxxX Server thread terminated (NN clients served, ...)` summary
line was logged to the GUI but never persisted to disk, hiding useful operational data (e.g. rate-limit / IP-filter denial counts) from
post-hoc analysis.

The `Stop->Enabled` half of the gate is original 2000-era code
(7e3e47141, "Initial check-in: v3.00c") and worked in practice for 25+
years by accident: the old `xxx_set_state` switch only handled
SERVER_STOPPED and SERVER_READY explicitly, so transitional states
fell through and left `Stop->Enabled` at its previous (true) value
through the entire shutdown sequence -- only flipping false on the
final SERVER_STOPPED callback that fires *after* the summary line is
emitted. The gate happened to be open at exactly the right moment.

f65fd89a1 ("Resolve crashes during graceful server termination(s)")
moved control updates out of the background-thread state callbacks
onto the 2 Hz LogTimer and rewrote the mapping as a strict flat
assignment:

MainForm->FtpStop->Enabled = (state == SERVER_READY);

That tightened `Stop->Enabled` from "best-effort proxy for
is-server-running" to literally `state == SERVER_READY`. As soon as
shutdown begins, state leaves SERVER_READY, the next LogTimer tick
flips the flag to false, and disk logging stops -- well before the
summary line is emitted. The fix didn't introduce the gate; it just
removed the slack that was masking it.

d0252720e ("sbbsctrl: Add 'Log to Disk' option for Terminal and Web
servers", resolves #1108) then added disk logging to Telnet and Web
and copied the Mail/FTP gate pattern verbatim, so those two arrived
broken.

Drop the `XxxStop->Enabled` half of the gate in all four handlers;
the user's "Log to Disk" preference alone is the right condition.

Resolves #1146

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
--- SBBSecho 3.37-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/commit/1082de20dca523f276c780ba
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
sbbsctrl: fflush per-server disk-log streams after each write

Follow-up to 9a207243c (resolved #1146): with the Stop->Enabled gate
removed, the shutdown-summary line now reaches the disk-log fwrite() in
each of the four xxx_log_msg() handlers -- but rob noticed that the
line still didn't *appear* in the file until sbbsctrl was quit. Cause: _fsopen() returns a fully-buffered stream, and the handlers never flush; written data sits in the CRT buffer until the close sentinel (msg==NULL)
calls fclose() at sbbsctrl shutdown, or until the next date rollover
recreates the file.

Add a plain fflush(LogStream) after each fwrite(). On Windows this is essentially free -- fflush copies the CRT buffer to the OS page cache
(no FlushFileBuffers, no disk sync), and the OS handles physical
writeback on its own schedule -- so per-line flushing is fine and
avoids the "lines stranded indefinitely after the last write of a
quiet period" failure mode of any timer/threshold-based scheme.

Same provenance as the previous fix: the missing-fflush has been in
the Mail/FTP handlers since the initial v3.00c import in 2000
(7e3e47141), and was propagated to the new Telnet/Web handlers in
d0252720e (resolves #1108).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
--- SBBSecho 3.37-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)