https://gitlab.synchro.net/main/sbbs/-/commit/bb60b17eb2222447693f4dc9
Modified Files:
exec/avatars.js dyndns.js email_sec.js emailfiles.js inactive_user_email.js exec/load/avatar_lib.js modopts.js nodelist_options.js xtrnmenulib.js exec/msglist.js nodelist.js podcast.js postmeme.js postxtrn.js prextrn.js privatemsg.js qnet-ftp.js rlogin.js sbbsimsg.js sbbslist.js str_cmds.js telgate.js xtrn_sec.js
Log Message:
Use load() instead of load({}, ...) for value-returning scripts
Scripts like modopts.js and nodelist_options.js are designed to return
a value via their completion value (the result of the last expression evaluated). SpiderMonkey 128's JS::ExecuteInJSMEnvironment() -- used
when a scope object {} is passed to load() -- returns only a bool success/failure, not the script's completion value. This causes these
load() calls to return the scope object instead of the intended value.
Remove the unnecessary scope object {} from load() calls to modopts.js
and nodelist_options.js so the scripts execute in the caller's scope
and their completion values are returned correctly.
Co-Authored-By: Claude Opus 4.6 <
noreply@anthropic.com>
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net